Re: [PATCH 3/3] [RFC] nmi_watchdog: config option to enable newnmi_watchdog

[Don Zickus]

On Tue, Feb 02, 2010 at 08:29:02AM +0100, Ingo Molnar wrote:
> > 
> > Ok.  I guess I am confused what you are suggesting here, to do as Peter 
> > suggested and run both at the same time?
> 
> I dont think we want to run old and new code at once, the old NMI watchdog 
> code is really a hardcoded minimal PMU driver generating a cycles based NMI 
> tick once per second.

Ok.  Agreed.

> 
> > > What do you think?
> > 
> > I will need to give you an updated patch that properly sets the frequency 
> > of the NMI and I probably should still implement a code path that uses the 
> > software perf counters in the cases where the hardware perf counters are 
> > not available.
> > 
> > It seems like you are ok with my approach.  If that is so, I can test on 
> > more machines to iron out some more bugs.  Or did you want to take my 
> > patches as is and have me throw fixes on top?
> 
> Well, all known bugs/showstoppers should be fixed - but otherwise if you 
> think it works fine we can certainly apply it and then iterate it from that 
> point on to increase coverage and add features.

I have a small cleanup to my second patch that makes it functional.  I'll
run some tests on some more machines and post version two tomorrow.  We
can probably build from there.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/