Re: [PWM PATCH 1/5] API to consolidate PWM devices behind a commonuser and kernel interface

[Bill Gatliff]

H Hartley Sweeten wrote:
>> +	for (wchan = 0; wchan < pwm->nchan; wchan++) {
>> +		if (pwm->channels[wchan].flags & FLAG_REQUESTED) {
>>     
>
> Shouldn't this be:
>
> 	& BIT(FLAG_REQUESTED)
>
>   

Yes.  I've fixed that one several times now!  I think I need to review
my git-fu, especially rebasing.

> Nitpick... Can you move the #ifndef/#define to after the comment?
>   

I did that in all the others, I guess I missed this one...


b.g.

-- 
Bill Gatliff
bgat@xxxxxxxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/