Re: [PATCH RESEND] mfd: Add support for the timberdale FPGA.

[Richard Röjfors]

On 02/03/2010 11:45 AM, Samuel Ortiz wrote:
> Hi Richard,
>
> On Wed, Feb 03, 2010 at 09:39:47AM +0000, Richard Röjfors wrote:
> > The timberdale FPGA is found on the Intel in-Vehicle Infotainment reference board
> > russelville.
> >
> > The driver is a PCI driver which chunks up the I/O memory and distributes interrupts
> > to a number of platform devices for each IP inside the FPGA.
> >
> > Signed-off-by: Richard Röjfors<richard.rojfors@xxxxxxxxxxxxxx>
> The patch looks good to me, I have a couple of minor comments though:
>
> - Please replace most of your printk with dev_dbg/err()

Agreed.

> - Please fix your checkpatch output:
> total: 255 errors, 18 warnings, 822 lines checked

Sweet, the mail client changed all tabs to spaces when resending the patch.

--Richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/