Re: [PATCHv2 08/11] fec: fix uninitialized rx buffer usage

[Grant Likely]

On Wed, Feb 3, 2010 at 11:33 AM, Amit Kucheria
<amit.kucheria@xxxxxxxxxxxxx> wrote:
> On Wed, Feb 3, 2010 at 8:46 AM, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:
>> On Tue, Feb 2, 2010 at 10:16 PM, Amit Kucheria
>> <amit.kucheria@xxxxxxxxxxxxx> wrote:
>>> From: Rob Herring <r.herring@xxxxxxxxxxxxx>
>>>
>>> The fec driver was enabling receive buffer descriptor without allocating
>>> the buffers. Make sure the buffer descriptors are initialized to not
>>> start receiving packets.
>>>
>>> Open also calls fec_restart after the rx buffers are allocated. With the code
>>> in fec_restart, it zeroes out the buffer descriptors that have just been
>>> setup.
>>
>> fec related patches 8 & 9 look okay to me.
>>
>> g.
>>
>> --
>> Grant Likely, B.Sc., P.Eng.
>> Secret Lab Technologies Ltd.
>
> Can I take that as an Acked-by?

of course.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/