Re: [PATCH 1/9] platform-drivers: move probe to .devinit.text in arch/arm

From: Rtp
Date: Thu Feb 04 2010 - 16:24:42 EST


Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx> writes:

> A pointer to a probe callback is passed to the core via
> platform_driver_register and so the function must not disappear when the
> .init sections are discarded. Otherwise (if also having HOTPLUG=y)
> unbinding and binding a device to the driver via sysfs will result in an
> oops as does a device being registered late.
>
> An alternative to this patch is using platform_driver_probe instead of
> platform_driver_register plus removing the pointer to the probe function
> from the struct platform_driver.
>
> Signed-off-by: Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Arnaud Patard <arnaud.patard@xxxxxxxxxxx>
> Cc: Ben Dooks <ben-linux@xxxxxxxxx>
> Cc: Dmitry Baryshkov <dbaryshkov@xxxxxxxxx>
> Cc: Eric Miao <eric.miao@xxxxxxxxxxx>
> Cc: Kristoffer Ericson <Kristoffer.Ericson@xxxxxxxxx>
> Cc: Liam Girdwood <liam.girdwood@xxxxxxxxxxxxxxxx>
> Cc: Paul Sokolovsky <pmiscml@xxxxxxxxx>
> Cc: Richard Purdie <rpurdie@xxxxxxxxx>
> Cc: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
> ---
> arch/arm/mach-pxa/corgi_ssp.c | 2 +-
> arch/arm/mach-pxa/sharpsl_pm.c | 2 +-
> arch/arm/mach-s3c2410/h1940-bluetooth.c | 2 +-
> arch/arm/mach-sa1100/jornada720_ssp.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)

For the h1940-bluetooth change :
Acked-by: Arnaud Patard <arnaud.patard@xxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/