Re: [linux-pm] [PATCH 1/2] PM / Runtime: Add sysfs switch for disablingdevice run-time PM (rev. 2)

[Nigel Cunningham]

Hi Pavel et al.

Pavel Machek wrote:
> Hi!
> 
>>  /*
>> + *	control - Report/change current runtime PM setting of the device
>> + *
>> + *	Runtime power management of a device can be blocked with the help of
>> + *	this attribute.  All devices have one of the following two values for
>> + *	the power/control file:
>> + *
>> + *	 + "auto\n" to allow the device to be power managed at run time;
>> + *	 + "on\n" to prevent the device from being power managed at run time;
> 
> I find interface with mandatory \n quite 'interesting'. 

Agreed.

> Plus english is strange here. All devices have ... "auto" to allow...?
> Strange formulation. List the values first, then add "write ... to allow"?

It seems okay to me because of the preceding sentence ending in a colon.

Regards,

Nigel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/