Re: [net-next PATCH v4 1/3] sysctl: refactor integer handling proccode

[Cong Wang]

Octavian Purdila wrote:
> On Tuesday 16 February 2010 10:41:07 you wrote:
>
> > > +
> > > +     if (!write && !first && left && !err)
> > > +             err = proc_put_newline(&buffer, &left);
> > > +     if (write && !err)
> > > +             err = proc_skip_wspace(&buffer, &left);
> > > +     if (err == -EFAULT /* do we really need to check for -EFAULT? */ ||
> > > +         (write && first))
> > > +             return err ? : -EINVAL;
> > The logic here seems messy, adding one or two goto's may help?
>
> OK, I'll give it a try. 
>
> What about the EFAULT check, is that really required?

I think so, it means to keep the errno to user-space when it is EFAULT,
right? This seems reasonable.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/