Re: [PATCH] driver/misc: Add new driver for Avago ADJD-S371-QR999

[Andrew Morton]

On Sun, 14 Feb 2010 23:08:16 +0900
NISHIMOTO Hiroki <tlayboy@xxxxxxxxx> wrote:

> Add new driver for Avago ADJD-S371-QR999 digital color sensor.
> 
> This driver has two functions.
> 1. raw_color
>        Gets color values of object.
> 2. trim_color
>        Gets color values of object except the influence of natural light.
> 
> Reset, sleep, external clock functions are not mandatory, so not implemented.
> 

There are quite a number of driver commands here which weren't
documented.  Please fully describe the proposed userspace interface
within the changelog.  Or, better, within a documentation file. 
Because the userspace interface is the most important part.  It's the
only thing we can never change.

It appears that the entire userspace interface for this driver is
implemented via sysfs?  This is odd - we used to have this thing called
"/dev" for communicating with device drivers.  What do people think
about this?

The proposed sysfs interface appears to emit multiple values from a
single sysfs file.  This is considered to be against the sysfs design
rules.

Note that all the above discusses the usersapce interface!  Once we get
that sorted out then we can start looking at the implementation.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/