[PATCH] Doc/SubmitChecklist: add rule #1

From: Randy Dunlap
Date: Tue Feb 16 2010 - 18:47:25 EST


From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>

Add header file requirements.
Complements of Stephen Rothwell.

Stephen calls this Rule #1, so I put it there, but I
didn't want to demote any of the others in the list,
so I made one of them number 2b.

Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
---
Documentation/SubmitChecklist | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

--- lnx-2633-rc8.orig/Documentation/SubmitChecklist
+++ lnx-2633-rc8/Documentation/SubmitChecklist
@@ -9,10 +9,14 @@ Documentation/SubmittingPatches and else
kernel patches.


-1: Builds cleanly with applicable or modified CONFIG options =y, =m, and
+1: If you use a facility then #include the file that defines/declares
+ that facility. Don't depend on other header files pulling in ones
+ that you use.
+
+2: Builds cleanly with applicable or modified CONFIG options =y, =m, and
=n. No gcc warnings/errors, no linker warnings/errors.

-2: Passes allnoconfig, allmodconfig
+2b: Passes allnoconfig, allmodconfig

3: Builds on multiple CPU architectures by using local cross-compile tools
or some other build farm.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/