Re: [PATCH 2/3] tracing/kprobes: Make Kconfig dependencies generic

[Mike Frysinger]

On Thu, Feb 18, 2010 at 07:09, Heiko Carstens wrote:
> On Thu, Feb 18, 2010 at 06:18:20AM -0500, Mike Frysinger wrote:
>> On Thu, Feb 18, 2010 at 06:13, Frederic Weisbecker wrote:
>> > --- a/arch/Kconfig
>> > +++ b/arch/Kconfig
>> > @@ -121,6 +121,9 @@ config HAVE_DMA_ATTRS
>> > Âconfig USE_GENERIC_SMP_HELPERS
>> > Â Â Â Âbool
>> >
>> > +config HAVE_REGS_AND_STACK_ACCESS_API
>> > + Â Â Â bool
>> > +
>>
>> could you add an appropriate help/comment so arch peeps know what
>> needs to be implemented before they can select this
>
> That's why I added the commit ID for the regs and stack access api
> to the changelog. imho that should be sufficient.
> Besides that the next commit would implement it for s390 as a
> blueprint for others. That is... for those that missed the initial
> x86 implementation.

people shouldnt have to dive into the changelog to try and divine
documentation.  it's hardly standard, so people fall on it in a
pima-last-resort kind of way.  being explicit in the file up front by
writing real documentation says other people a lot more time.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/