Re: printk_ratelimited() not compiling

[Joe Perches]

On Thu, 2010-02-18 at 14:36 -0800, john stultz wrote: 
> > Am I missing something obvious, or did something get broken after this went in?
> Ok. Solved it. I needed to #include <linux/ratelimit.h> in the file I
> was adding the printk_ratelimited usage in, rather then where
> printk_ratelimited is defined.
> 
> Maybe would it be better to move the printk_ratelimited definitions into
> ratelimit.h so this would be more obvious?

That's one option.

Probably the only places I tried it had an
#include <linux/net.h> somewhere which does an
#include <linux/ratelimit.h>

Personally, I think it'd be better to put
#include <linux/ratelimit.h> back in kernel.h
Commit 3fff4c42bd0a89869a0eb1e7874cc06ffa4aa0f5 removed it.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/