Re: [PATCH -mm] frv: remove the obsolete and unnecessary DMA APIcomments

[FUJITA Tomonori]

On Wed, 17 Feb 2010 10:03:42 +0000
David Howells <dhowells@xxxxxxxxxx> wrote:

> FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> wrote:
> 
> > pci_dma_sync_single was obsoleted long ago.
> > 
> > All the comments are generic, not architecture specific, simply
> > describes some of the DMA-API (and frv has the same comments in three
> > files). Documentation/DMA-API.txt have more detailed descriptions.
> > 
> > This removes the above obsolete and unnecessary DMA API
> > comments. Let's describe the DMA API in only
> > Documentation/DMA-API.txt.
> 
> I'm okay with this, _provided_ you put a pointer in a banner comment at the
> top of the file to Documentation/DMA-API.txt.

How about this?

=
From: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
Subject: [PATCH] frv: add a pointer to Documentation/DMA-API.txt

Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
---
 arch/frv/include/asm/dma-mapping.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/arch/frv/include/asm/dma-mapping.h b/arch/frv/include/asm/dma-mapping.h
index 20cca40..6af5d83 100644
--- a/arch/frv/include/asm/dma-mapping.h
+++ b/arch/frv/include/asm/dma-mapping.h
@@ -7,6 +7,11 @@
 #include <asm/scatterlist.h>
 #include <asm/io.h>
 
+/*
+ * See Documentation/DMA-API.txt for the description of how the
+ * following DMA API should work.
+ */
+
 #define dma_alloc_noncoherent(d, s, h, f) dma_alloc_coherent(d, s, h, f)
 #define dma_free_noncoherent(d, s, v, h) dma_free_coherent(d, s, v, h)
 
-- 
1.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/