Re: [PATCH 34/35] x86: use num_processors for possible cpus

From: Christoph Lameter
Date: Fri Feb 19 2010 - 10:14:31 EST


On Thu, 18 Feb 2010, H. Peter Anvin wrote:

> > As I have also repeatedly stated: Dynamic percpu data allocation when
> > onlining / offlining processors will complicate locking (cannot rely on
> > percpu be present anymore) and introduce numerous additional
> > hotplug notifiers into subsystems.
>
> I did state explicitly "on first up". Trying to free it would be
> insane. There are a couple of subsystems which are percpu memory
> pigs... so far it's not clear any of them actually matters in a
> production kernel. 60K * 16 phantom processors is still ~ 1 MB, which
> probably isn't enough to worry about but isn't great.

The first up still means the addition of notifiers for subsystems that
have to initialilze their per cpu data and dealing with potential races
that would be caused by adding those.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/