Re: [PATCH]Add new device drivers for Topcliff

[Alan Cox]

> Following drivers are available now.
> 
> [Device name} [File name]
> Common patch common_patch.tar.bz2
> CAN  can.tar.bz2
> DMA  dma.tar.bz2
> GbE  gbe.tar.bz2
> GPIO  gpio.tar.bz2
> I2C  i2c.tar.bz2
> IEEE1588 ieee1588.tar.bz2
> Packet HUB pcieqos.tar.bz2
> SPI  spi.tar.bz2
> UART  uart.tar.bz2
> USB Device usbdev.tar.bz2

I downloaded a few of these to look at.

You need to generate them with "diff -u" - that will make them
more readable and mean they can be applied reliably to file versions that
may have changed. They also contain unrelated/debugging changes you have
made and which you probably want to remove from the submission

eg:


! 			kunmap(miter->page);
  
  		miter->page = NULL;
  		miter->addr = NULL;
--- 402,409 ----
  			WARN_ON(!irqs_disabled());
  			kunmap_atomic(miter->addr, KM_BIO_SRC_IRQ);
  		} else
! //			kunmap(miter->page);
!  			kunmap(miter->page);


The code looks quite reasonable although not in the kernel style. We have
the staging directory so we can take submissions that still need clean up
so that is not an immediate concern.

I am unsure about the serial driver. The 8250 driver is already very
complicated. It might be better to make a copy of 8250, remove all the
other special cases and create a new driver for the IOH DMA serial port.
We can discuss that.

If you can create a set in diff -u format, I will go through them in more
detail and send further suggestions.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/