Re: Regression in ptrace (Wine) starting with 2.6.33-rc1, fixes

From: Frederic Weisbecker
Date: Fri Feb 19 2010 - 12:17:49 EST


On Thu, Feb 18, 2010 at 08:27:41PM +0100, Michael Stefaniuc wrote:
> Thanks Frederic!
>
> On 02/18/2010 06:59 PM, Frederic Weisbecker wrote:
>> I still can't build the wine tree (even with the wine faq)
>> because of the following error:
>>
>> LD_LIBRARY_PATH="../../libs/wine:$LD_LIBRARY_PATH" ../../tools/wrc/wrc --nostdinc -I. -I. -I../../include -I../../include -D__WINESRC__ -D_KERNEL32_ -folocale_rc.res locale_rc.rc
>> Source: ïQïï a4 51 a4 eb
>> Unicode: 5341 6708
>> Back: ïÌï a2 cc a4 eb
>> nls/cht.nls:84:16: Error: String ïQïï does not convert identically to Unicode and back in codepage 950. Try using a Unicode string instead
>> make[1]: *** [locale_rc.res] Erreur 1
> Wow, what Wine version are you trying to build? That was a known
> regression but it was fixed 1-2 days later.
>


Hmm, it's a git clone from the wine repo, probably 5 days old.



>> So I can't test these fixes by myself (although I've tested locally
>> with a home made POKEUSER -> PEEKUSER match test).
>>
>> Could you please test the following tree? You can pull it on top
>> of Linus tree, or clone it.
>>
>> It's here:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
>> perf/urgent
> I have just applied your two patches on top of current git. I have run
> the specific test (make exception.ok) as well as full winetest.exe run:
> The ptrace regressions impacting Wine are all fixed.



Great!



> Thanks again for the quick resolution.
> bye


And thanks a lot for all your testing.
I'm adding your tested-by and will push the patches.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/