Re: [PATCH 01/10] checkstack: fix perlcritic warnings

[Cong Wang]

Stephen Hemminger wrote:
>Turn on strict checking.
>Get rid of prototypes (prototypes are broken in Perl)

NAK, please check perldoc of sort().
The prototype there is needed by sort().

>Fix syntax of declaration.

Yeah, this is fine.

BTW, your $subject needs to be fixed too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/