Re: [PATCH -mm 03/17] sysctl extern cleanup - binfmts

[Dave Young]

On Sun, Feb 21, 2010 at 10:28 PM, Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
> On Sun, Feb 21, 2010 at 10:23:03PM +0800, Dave Young wrote:
>> --- linux-2.6.32.orig/include/linux/binfmts.h
>> +++ linux-2.6.32/include/linux/binfmts.h
>> @@ -20,6 +20,11 @@ struct pt_regs;
>> Â#ifdef __KERNEL__
>> Â#include <linux/list.h>
>>
>> +/* for sysctl */
>
> This comment is neither accurate nor needed. :^)

Thanks, sounds good, but the there's no other file use the three vars.

>
> In fact master sysctl table always was a big mess, so slight mess
> caused by extern declarations is fine.
>
>> +extern int core_uses_pid;
>> +extern char *core_pattern;
>> +extern unsigned int core_pipe_limit;
>



-- 
Regards
dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/