Re: [net-next PATCH v5 2/3] sysctl: add proc_do_large_bitmap

[Cong Wang]

Octavian Purdila wrote:
> But I think its worth to keep the whitespaces in beetween, e.g. allow
>
> $ echo '1, 2 ,3 ' >   ip_local_reserved_ports.


Sure.

> > Also, if I write an invalid value, it does reject this, but the previous
> > value in that file is cleared, shouldn't we keep the previous one?
>
> The only way I see to fix this is to return EINVAL if we detect a write with offset.


Yeah, we shouldn't continue once we find any invalid value.

> IMO we should do that for the other proc write routines as well, as otherwise ther result is confusing, e.g.
>
> write("1 2"); write(" 3");
>
> will set first value in the vector to 1, than second value to 2 then *first* value to 3.
>
> I am all for it, but again, this changes userspace ABI. 

Sorry, is this related with the problem I mentioned above? Both "1 2"
and " 3" are valid values.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/