Re: [PATCH 05/06] kernel.h tracing stuff cleanup

[Steven Rostedt]

On Mon, 2010-02-22 at 22:20 +0800, Dave Young wrote:
> trace stuff in kernel.h should stay in their own head file 
> 
> cleanup trace declarations in kernel.h, put them into ring_buffer.h
> include ring_buffer.h in every file which need it

NAK, sorry.

1) it does not belong in ring_buffer.h. The ring buffer.h is for the
ring buffer only, and is agnostic to other tracing code.

2) trace_prink() and friends needs to be with printk. It is not used
much in the delivered kernel but it is used often in development. That
is, we purposely made it so it is not needed to add a header file to
everyplace you use trace_prink(). When debugging a problem,
trace_printk() needs to be as convenient as adding printk(), and by
needing to find "what header includes trace_printk()" will become an
overwhelming inconvenience.

-- Steve


> 
> Signed-off-by: Dave Young <hidave.darkstar@xxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/