Re: [PATCH] nmi_watchdog: checkpatch.pl cleanups from earlierpatches

[Cyrill Gorcunov]

On Mon, Feb 22, 2010 at 06:09:03PM -0500, Don Zickus wrote:
...

Hi Don!

> diff --git a/kernel/nmi_watchdog.c b/kernel/nmi_watchdog.c
> index 3c75cbf..0a6f57f 100644
> --- a/kernel/nmi_watchdog.c
> +++ b/kernel/nmi_watchdog.c
> @@ -50,31 +50,31 @@ void touch_all_nmi_watchdog(void)
>  
>  static int __init setup_nmi_watchdog(char *str)
>  {
> -        if (!strncmp(str, "panic", 5)) {
> -                panic_on_timeout = 1;
> -                str = strchr(str, ',');
> -                if (!str)
> -                        return 1;
> -                ++str;
> -        }
> -        return 1;
> +	if (!strncmp(str, "panic", 5)) {
> +		panic_on_timeout = 1;

If I understand all the things correct -- you don't need to check for ','
after panic. It seems so. Because we're switching to perf_events I suppose
we may drop expecting "lapic,ioapic" or whatever here? Or there is an idea
to parse say "panic,software" (ie to switch to software events by default)?

Though strictly speaking my question in rather unrelated to this patch
agenda :)

> +		str = strchr(str, ',');
> +		if (!str)
> +			return 1;
> +		++str;
> +	}
> +	return 1;
>  }
>  __setup("nmi_watchdog=", setup_nmi_watchdog);
...

	-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/