Re: [PATCH] failslab: add abitily to filter slab caches

From: Dmitry Monakhov
Date: Tue Feb 23 2010 - 09:02:24 EST


Akinobu Mita <akinobu.mita@xxxxxxxxx> writes:

> 2010/2/23 Dmitry Monakhov <dmonakhov@xxxxxxxxxx>:
>> Example:
>> echo 1 > /sys/kernel/slab/skbuff_head_cache/failslab
>> echo 1 > /sys/kernel/debug/failslab/cache-filter
>
> Looks good.
>
> .Should we also support clearing the flag by
> "echo 0 > /sys/kernel/slab/skbuff_head_cache/failslab" ?
But it already does this, any output except "1" treated as '0'
I've snipped this from trace option.
>
>> +static ssize_t failslab_store(struct kmem_cache *s, const char *buf,
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â size_t length)
>> +{
>> + Â Â Â s->flags &= ~SLAB_FAILSLAB;
>> + Â Â Â if (buf[0] == '1')
>> + Â Â Â Â Â Â Â s->flags |= SLAB_FAILSLAB;
>> + Â Â Â return length;
>> +}
>> +SLAB_ATTR(failslab);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/