Re: [patch 1/3] vmscan: factor out page reference checks

From: Rik van Riel
Date: Tue Feb 23 2010 - 09:32:00 EST


On 02/23/2010 09:21 AM, Johannes Weiner wrote:

From: Johannes Weiner<hannes@xxxxxxxxxxx>
Subject: vmscan: improve comment on mlocked page in reclaim

Signed-off-by: Johannes Weiner<hannes@xxxxxxxxxxx>
---

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 674a78b..819fff7 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -578,7 +578,10 @@ static enum page_references page_check_references(struct page *page,
if (sc->order> PAGE_ALLOC_COSTLY_ORDER)
return PAGEREF_RECLAIM;

- /* Mlock lost isolation race - let try_to_unmap() handle it */
+ /*
+ * Mlock lost the isolation race with us. Let try_to_unmap()
+ * move the page to the unevictable list.
+ */
if (vm_flags& VM_LOCKED)
return PAGEREF_RECLAIM;

Reviewed-by: Rik van Riel <riel@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/