RE: [PATCH] ARM: misplaced parentheses?

[Linus Walleij]

[Roel]

> The parentheses appear misplaced.
> 
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
> ---
> Correct?
> 
> diff --git a/arch/arm/mach-u300/gpio.c b/arch/arm/mach-u300/gpio.c
> index 0b35826..5f61fd4 100644
> --- a/arch/arm/mach-u300/gpio.c
> +++ b/arch/arm/mach-u300/gpio.c
> @@ -546,7 +546,7 @@ static void gpio_set_initial_values(void)
>  	for (i = 0; i < U300_GPIO_MAX; i++) {
>  		val = 0;
>  		for (j = 0; j < 8; j++)
> -			val |= 
> (u32)((u300_gpio_config[i][j].pull_up == DISABLE_PULL_UP)) << j;
> +			val |= 
> (u32)((u300_gpio_config[i][j].pull_up == DISABLE_PULL_UP) << j);
>  		local_irq_save(flags);
>  		writel(val, virtbase + U300_GPIO_PXPER + i * 
> U300_GPIO_PORTX_SPACING);
>  		local_irq_restore(flags);

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>

BTW this should go in through Russells patch tracker, can you
put it there?
http://www.arm.linux.org.uk/developer/patches/

Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/