Re: [PATCH -v2 2/2] genericirq: change ack/mask in irq_chip to takeirq_desc instead of irq

[Thomas Gleixner]

On Wed, 3 Mar 2010, Yinghai Lu wrote:
> > 
> > The right way to do that is 
> > 
> >   1) add new function pointers, which take irq_desc as their argument
> > 
> >   2) make the generic code use them when the old function pointer is
> >      NULL
> > 
> >   3) convert the irq_chip implementations one by one with separate
> >      patches
> > 
> >   4) Remove the old function pointers and switch the generic code
> >      fully over to use the new ones
> > 
> > Yes, it's more work, but it's less error prone and easier to review,
> > as the maintainers just have to look at the patch which affects their
> > particular area.
> 
> good. please check if you are happy with this version.

It's better, but again please provide separate patches for:

     1) the new function pointers

     2) kernel/irq/* making use of them

     3) separate patches for each irq_chip conversion. If several
        chips share the same mask/unmask/etc. functions, then one
        patch for converting those related ones is fine.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/