Re: [PATCH] msdos: add support for large disks

From: OGAWA Hirofumi
Date: Mon Mar 08 2010 - 04:36:28 EST


"H. Peter Anvin" <hpa@xxxxxxxxx> writes:

> On 03/07/2010 04:09 PM, OGAWA Hirofumi wrote:
>>
>> It means,
>>
>> min(size, max(logical_sector_size / 512, 2));
>>
>> or like this? ("size" is "nr_sects(part) * (logical_sector_size/512)")
>>
>> This should keep old logic, i.e. if partition is bigger than 1kb, it
>> uses 1kb for (probably) LILO mentioned by comment.
>>
>
> I don't really know where the 1K cames from, and it isn't necessarily
> safe, either.

Um..., I see. However, it wouldn't also be the reason to remove this 1kb
logic. So, I'll just use the above code with some comments for now,
it'll be by separated incremental patch though.

Thanks.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/