Re: [PATCH] usb-serial: Fix usb serial console open/close regression

[Alan Stern]

On Mon, 8 Mar 2010, Jason Wessel wrote:

> > This is a little unfortunate.  It would be better to prevent
> > tty_port_shutdown() from clearing ASYNCB_INITIALIZED in the first
> > place.  The problem is that the tty core doesn't know when the port is
> > being used as a console.  There ought to be a way to tell it.
> >   
> 
> I agree, but presently there is no way to do so.   Up until 2.6.33 the
> ASYNCB_INITIALIZED was being used to track this, but now it is used a
> bit differently.
> 
> We still also have the same sort of issue for the passing in the initial
> baud.  I don't know if you want to go for a short term approach this
> way, or try to implement something different right now.  When you do
> consider something longer term, I would like it to incorporate the other
> serial settings as well, such that if the console initializes them first
> the get correctly inherited by the tty open().

I don't want to make any changes before hearing from Alan Cox.  Doing 
the right thing probably means switching all the tty drivers over to 
the tty_port model.  I don't know which ones still need to be changed.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/