Re: mm: Do not iterate over NR_CPUS in __zone_pcp_update()

From: Tejun Heo
Date: Mon Mar 08 2010 - 21:07:23 EST


On 03/08/2010 10:29 PM, Pekka Enberg wrote:
> On Mon, Mar 8, 2010 at 11:21 AM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>> __zone_pcp_update() iterates over NR_CPUS instead of limiting the
>> access to the possible cpus. This might result in access to
>> uninitialized areas as the per cpu allocator only populates the per
>> cpu memory for possible cpus.
>>
>> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>
> Looks OK to me.
>
> Acked-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>

Yeap, that's buggy.

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

I suppose this would go through the mm tree?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/