Re: [PATCH 07/11] ST SPEAr: Added source files for SPEAr3xx machine family

[Viresh KUMAR]

Hi Linus,

On 3/9/2010 12:16 PM, Linus Walleij wrote:
> Hi Viresh,
> some smallish comments...
> 
> 2010/3/3 Viresh KUMAR <viresh.kumar@xxxxxx>:
> 
>> (skip some stuff that looks OK...)
>> diff --git a/arch/arm/mach-spear3xx/spear3xx.c b/arch/arm/mach-spear3xx/spear3xx.c
>> new file mode 100644
>> index 0000000..f529d74
>> --- /dev/null
>> +       .res = {
>> +               .start = SPEAR3XX_ICM1_UART_BASE,
>> +               .end = SPEAR3XX_ICM1_UART_BASE + SPEAR3XX_ICM1_UART_SIZE - 1,
>> +               .flags = IORESOURCE_MEM,
>> +               },
>> +       .irq = {IRQ_UART, NO_IRQ},
>> +       .periphid = 0x00041011,
>> +};
> 
> You're hardcoding the PrimeCell ID to the ARM version, but I suspect
> you have an ST derivate with some additional features. If you look in
> the PL011 driver in drivers/serial/amba-pl011.c you will probably recognize
> the modified PrimeCell IDs for vendor 0x80 (VENDOR_ST) and I think
> you might rather need to patch this file with your new periphid and
> possibly even implement some new extensions (if there are any).
> 
> What value is actually in the ID registers of your cell? (Just
> check in some debugger or simply printk() it...)
> 
> Apart from this the patch looks OK to me.
> 

Actually PL011 is customized by ST's nomadik platform. And hence above
is true for nomadik only. We are using ARM's version of PL011 without
any customization over it and so id for our case is still 0x00041011.

regards,
viresh kumar.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/