Re: still worth running kernel cleanup scripts after mergewindows?

[Robert P. J. Day]

On Mon, 8 Mar 2010, Randy Dunlap wrote:

> On 03/08/10 05:07, Robert P. J. Day wrote:

> >   as a single example, here's a snippet from the
> > drivers/message/fusion directory, identifying an apparently bad
> > reference to a non-existent CONFIG variable:
> >
> >>>>>> FUSION_MAX_FC_SGE
> > drivers/message/fusion/mptbase.h:179:#ifdef CONFIG_FUSION_MAX_FC_SGE
> > drivers/message/fusion/mptbase.h:180:#if CONFIG_FUSION_MAX_FC_SGE  < 16
> > drivers/message/fusion/mptbase.h:182:#elif CONFIG_FUSION_MAX_FC_SGE  > 256
> > drivers/message/fusion/mptbase.h:185:#define MPT_SCSI_FC_SG_DEPTH  CONFIG_FUSION_MAX_FC_SGE
> >
> >   but there is no such Kconfig variable FUSION_MAX_FC_SGE.  however:
> >
> > $ grep -r FUSION_MAX drivers/message/fusion
> > drivers/message/fusion/Kconfig:config FUSION_MAX_SGE
> > drivers/message/fusion/mptbase.h:#ifdef CONFIG_FUSION_MAX_SGE
> > drivers/message/fusion/mptbase.h:#if CONFIG_FUSION_MAX_SGE  < 16
> > drivers/message/fusion/mptbase.h:#elif CONFIG_FUSION_MAX_SGE  > 128
> > drivers/message/fusion/mptbase.h:#define MPT_SCSI_SG_DEPTH	CONFIG_FUSION_MAX_SGE
> > drivers/message/fusion/mptbase.h:#ifdef CONFIG_FUSION_MAX_FC_SGE
> > drivers/message/fusion/mptbase.h:#if CONFIG_FUSION_MAX_FC_SGE  < 16
> > drivers/message/fusion/mptbase.h:#elif CONFIG_FUSION_MAX_FC_SGE  > 256
> > drivers/message/fusion/mptbase.h:#define MPT_SCSI_FC_SG_DEPTH	CONFIG_FUSION_MAX_FC_SGE
> > $
> >
> >   so is that a typo?  should "FUSION_MAX_FC_SGE" really be just
> > "FUSION_MAX_SGE"?  anyway, you get the idea.  or maybe i should just
> > put the scripts up at my wiki and people can run their at their
> > leisure on whatever part of the source tree interests them.
>
> Yes, please.

http://www.crashcourse.ca/wiki/index.php/Kernel_cleanup_scripts

have fun.  (only the first script is there at the moment, additional
scripts to appear shortly.)

rday
--



========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

            Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday
========================================================================
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/