Re: [PATCH 2/7] HID: N-trig MTM Driver fix and cleanup patch 2

From: Stéphane Chatty
Date: Tue Mar 09 2010 - 10:43:21 EST



Le 9 mars 10 à 02:07, Rafi Rubin a écrit :

case HID_DG_HEIGHT:
hid_map_usage(hi, usage, bit, max,
EV_ABS, ABS_MT_TOUCH_MINOR);
- input_set_abs_params(hi->input, ABS_MT_ORIENTATION,
- 0, 1, 0, 0);

Stephane added the orientation to height, I can't comment about the wisdom of pulling it.

The MT kernel protocol says that width/height is reported through TouchMinor/TouchMajor/Orientation. Orientation needs to be added somewhere. Doing it when encountering width or height seemed a logical thing to do, but I would see no objection at doing it somewhere else with TouchMinor and TouchMajor.

Cheers,

St.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/