Re: [RFC][PATCH] IRQ: Fix oneshot irq race between irq_finalize_oneshotand handle_level_irq

[Thomas Gleixner]

Lars-Peter,

On Tue, 9 Mar 2010, Lars-Peter Clausen wrote:
> > Right it's a valid SMP problem, but I got confused by the lengthy
> > explanation of a thread preempting an hard interrupt handler. :)
>
> Yes, sorry for bothering you with that. I actually had the symptoms
> described on a non SMP system. The irq in question was part of a
> longer irq chain and I though that it might be detached from the
> hardirq context somewhere along the chain.
> After your comment I reread some parts and it turned out that
> irq_enter()/irq_exit() was missing around the first level irq handler.

I'm happy you stared at that code even if you came to the wrong
conclusion vs. the problem that triggered your patch. You pointed out
a real bug in the code, which did not yet trigger because UP is not
affected and usually irqbalance pins irqs and also the irq threads to
a single cpu.

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/