madness, was Re: [PATCH 2/2] Macintosh: fix coding style issues inadb.c This is a patch to the adb.c file that cleans up many warnings foundby the checkpatch.pl tool

From: fthain
Date: Tue Mar 09 2010 - 22:57:53 EST

Next message: Paul Mundt: "Re: [PATCH] driver core: Early dev_name() support."
Previous message: Balbir Singh: "Re: [PATCH mmotm 2.5/4] memcg: disable irq at page cgroup lock (Re:[PATCH -mmotm 3/4] memcg: dirty pages accounting and limitinginfrastructure)"
In reply to: Michael Beardsworth: "[PATCH 2/2] Macintosh: fix coding style issues in adb.c This is a patch to the adb.c file that cleans up many warnings found by the checkpatch.pl tool. Signed-off-by: Michael Beardsworth <mbeards2@uoregon.edu>"
Next in thread: Benjamin Herrenschmidt: "Re: madness, was Re: [PATCH 2/2] Macintosh: fix coding styleissues in adb.c This is a patch to the adb.c file that cleans up manywarnings found by the checkpatch.pl tool"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, 9 Mar 2010, Michael Beardsworth wrote:

> - /* If a probe is in progress or we are sleeping, wait for it to complete */
> + /* If a probe is in progress or we are sleeping, wait until complete */

If you must "fix" what aint broke, please try not to damage it. I'm sorry
if your VT52 is limited to 80 cols, but IMNSHO this sort of effort is
misguided.

Maybe I could point out again (I do this periodically) that checkpatch.pl
is great but code that fails it is NOT always wrong.

"Check patch" is a good idea but "check existing code" is a waste of
everyone's time.

Finn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/