Re: [PATCH 02/11] ST SPEAr: Added basic header files for SPEAr3xx machine family

[Linus Walleij]

2010/3/10 Viresh KUMAR <viresh.kumar@xxxxxx>:
> On 3/10/2010 2:12 AM, Linus Walleij wrote:

>> If you want to keep this file anyway, move it from mach-spear3xx/include/mach
>> to just mach-spear3xx and include like this: #include "misc_regs.h" and
>> thus avoid the entire drivers/* tree (etc) from being able to #include
>> <mach/misc_regs.h>
>> because surely any machine-specific special driver using these very
>> machine-specific
>> registers will be in mach-spear3xx/ anyway.
>
> Surely, any standard driver will not use them. Actually we have kept clock
> framework code common to different machines in plat-spear.
> And here we need to use misc_regs.h, for this reason i kept it in
> mach/include/mach.

Okay so the plat-spear code use <mach/misc_regs.h> that is different
between different machines? Then it's correct of course, sorry for going
astray, please keep it there then.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/