Re: [PATCH 1/3] lockdep: Move lock events under lockdep recursionprotection

From: Jens Axboe
Date: Wed Mar 10 2010 - 10:56:21 EST


On Wed, Mar 10 2010, Peter Zijlstra wrote:
> On Wed, 2010-03-10 at 01:05 +0100, Frederic Weisbecker wrote:
> > On Tue, Mar 09, 2010 at 09:35:37AM +0100, Jens Axboe wrote:
> > > Which, btw, throws a new lockdep warning fest:
> > >
> > > [ 42.247718] scsi7 : ioc0: LSISAS1068E B3, FwRev=011b0300h,
> > Ports=1, MaxQ=483, IRQ=26
> > > [ 42.281125] BUG: key ffff880c7cb75250 not in .data!
> > > [ 42.288346] ------------[ cut here ]------------
> > > [ 42.294490] WARNING: at kernel/lockdep.c:2706 lockdep_init_map
> > +0x545/0x5f0()
> > > [ 42.304013] Hardware name: QSSC-S4R
> > > [ 42.309674] Modules linked in: hid_apple usbhid ehci_hcd uhci_hcd
> > usbcore nls_base mptsas(+) mptscsih mptbase scsi_transport_sas igb sg
> > sr_mod cdrom
> > > [ 42.332072] Pid: 5197, comm: modprobe Not tainted 2.6.34-rc1 #176
> > > [ 42.340597] Call Trace:
> > > [ 42.345335] [<ffffffff8107fb8d>] ? is_module_address+0x2d/0x60
> > > [ 42.353670] [<ffffffff81074aa5>] ? lockdep_init_map+0x545/0x5f0
> > > [ 42.362154] [<ffffffff81044648>] warn_slowpath_common+0x78/0xd0
> > > [ 42.371913] [<ffffffff810446af>] warn_slowpath_null+0xf/0x20
> > > [ 42.380109] [<ffffffff81074aa5>] lockdep_init_map+0x545/0x5f0
> >
> >
> >
> > This doesn't look related to my patch, it also happen in -rc1 right?
>
>
> The per-cpu changes broke lockdep, Tejun already posted patches for
> this:
>
> http://lkml.org/lkml/2010/3/10/76
> http://lkml.org/lkml/2010/3/10/79

Ah good, saves me the trouble of locating it, thanks!

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/