Re: Tuxradar patching article and [PATCH] scripts/cvt_kernel_style.pl

[Stefan Richter]

Joe Perches wrote:
> There was an article published recently:
> http://www.tuxradar.com/content/newbies-guide-hacking-linux-kernel
> that seems to have prompted several new contributors (welcome)
> to create style reformatting patches.

Uh oh.  How can a newcomer know what good style is?

Please start your career of kernel contributions differently:
  - Test new kernels.  Report issues and work with the developers to
    get the issues fixed.
  - If there is a bug which nags you but there doesn't seem to be
    an active developer to fix it anytime soon, try to fix it yourself.

Or if you are aware of a small RFE for a subsystem which interests you
personally, try to implement that small feature.

It doesn't make sense to start kernel development with something which
you are likely not going to connect with personally.  (Reformat others'
code?  Better write your own code, i.e. a bug fix or a small feature.)

PS:
I am also saying this because I repeatedly see "style fixes" posted
which are questionable at best, or actually degrade style, or even
introduce bugs.

PPS:
How can a script know what good style is?
-- 
Stefan Richter
-=====-==-=- --== -=-=-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/