Re: [RFC PATCH 6/6] sparc64: use early_res and nobootmem

From: Yinghai Lu
Date: Wed Mar 10 2010 - 17:21:22 EST


On 03/10/2010 02:04 PM, David Miller wrote:
> From: Yinghai Lu <yinghai@xxxxxxxxxx>
> Date: Wed, 10 Mar 2010 13:24:27 -0800
>
>> use early_res/fw_memmap to replace lmb, so could use early_res replace bootme
>> later.
>>
>> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
>
> This doesn't boot, it looks like early_res is not initialized
> early enough, the backtrace is:
>
> [ 0.000000] Remapping the kernel... done.
> [ 0.000000] Kernel panic - not syncing: can not find more space for early_res array
> [ 0.000000] Call Trace:
> [ 0.000000] [0000000000882c48] __check_and_double_early_res+0xc0/0x1c8
> [ 0.000000] [0000000000882f18] reserve_early+0x10/0x38
> [ 0.000000] [000000000087b894] prom_early_alloc+0x48/0x7c
> [ 0.000000] [000000000087b3e4] get_one_property+0x28/0x50
> [ 0.000000] [000000000087b588] prom_create_node+0x44/0xe8
> [ 0.000000] [000000000087b6d0] prom_build_tree+0x1c/0xac
> [ 0.000000] [000000000087b7b4] prom_build_devicetree+0x54/0x80
> [ 0.000000] [000000000087fd34] paging_init+0x69c/0x1268
> [ 0.000000] [00000000008786f4] start_kernel+0x88/0x374
> [ 0.000000] [000000000070589c] tlb_fixup_done+0x98/0xa0
> [ 0.000000] [0000000000000000] (null)

looks like we need to increase MAX_EARLY_RES_X in kernel/early_res.c

/*
* need to make sure this one is bigger enough before
* find_fw_memmap_area could be used
*/
#define MAX_EARLY_RES_X 32

struct early_res {
u64 start, end;
char name[15];
char overlap_ok;
};
static struct early_res early_res_x[MAX_EARLY_RES_X] __initdata;

static int max_early_res __initdata = MAX_EARLY_RES_X;


or can you check if setup_memory_map() can be moved that early?
(try to use early_param for mem=, so need to move that earlier)...

YH

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/