Re: [patch] numa: fix BUILD_BUG_ON for node_read_distance

From: Greg KH
Date: Wed Mar 10 2010 - 18:01:00 EST


On Wed, Mar 10, 2010 at 02:50:21PM -0800, David Rientjes wrote:
> node_read_distance() has a BUILD_BUG_ON() to prevent buffer overruns when
> the number of nodes printed will exceed the buffer length.
>
> Each node only needs four chars: three for distance (maximum distance is
> 255) and one for a seperating space or a trailing newline.

Is this causing a problem as-is today that we need to resolve for
2.6.34? Or is this 2.6.35 material?

Who chose this original number, and why is it off by 1/2?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/