Re: [PATCH 4/5] fs: fat: use hex_asc_lo/hex_asc_hi instead of custom one

[OGAWA Hirofumi]

Andy Shevchenko <andy.shevchenko@xxxxxxxxx> writes:

>  			if (uni_xlate == 1) {
> -				*op = ':';
> -				for (k = 4; k > 0; k--) {
> -					nc = ec & 0xF;
> -					op[k] = nc > 9	? nc + ('a' - 10)
> -							: nc + '0';
> -					ec >>= 4;
> -				}
> -				op += 5;
> +				*op++ = ':';
> +				*op++ = hex_asc_hi(ec >> 8);
> +				*op++ = hex_asc_lo(ec >> 8);
> +				*op++ = hex_asc_hi(ec);
> +				*op++ = hex_asc_lo(ec);
>  				len -= 5;

Why doesn't this use pack_hex_byte()?

Thanks.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/