Re: [PATCH 05/11] ST SPEAr: Added clock framework for SPEArplatform and machines

[Russell King - ARM Linux]

On Wed, Mar 03, 2010 at 10:37:35AM +0530, Viresh KUMAR wrote:
> +/* array of all spear 3xx clock lookups */
> +static struct clk_lookup *spear_clk_lookups[] = {
> +	/* root clks */
> +	&osc_32k_cl,
> +	&osc_24m_cl,

This is rather wasteful - rather than defining structures, and then having
a one-time-used set of pointers to the structures, why not just declare
the whole lot as an array like most other implementations do?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/