Re: DMA_ERROR_CODE (was: Re: linux-next: build failure after mergeof the final tree)

[David Woodhouse]

On Thu, 2010-03-11 at 09:15 +0900, FUJITA Tomonori wrote:
> On Wed, 10 Mar 2010 12:03:37 +0100
> Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> 
> > On Mon, Mar 1, 2010 at 10:40, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> > > After merging the final tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> > >
> > > drivers/mtd/nand/r852.c:22: error: 'enable_dma' redeclared as different kind of symbol
> > > arch/powerpc/include/asm/dma.h:189: note: previous definition of 'enable_dma' was here
> > > drivers/mtd/nand/r852.c: In function 'r852_engine_enable':
> > > drivers/mtd/nand/r852.c:545: error: implicit declaration of function 'msleep'
> > >
> > > Caused by commit 67e054e919248fa1db93de727fb9ad49eb700642 ("mtd: nand:
> > > Add driver for Ricoh xD/SmartMedia reader") from the mtd.
> > >
> > > I applied the following patch for today.
> > >
> > > From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> > > Date: Mon, 1 Mar 2010 20:21:06 +1100
> > > Subject: [PATCH] mtd: nand: fix name space clash
> > >
> > > and include delay.h for msleep().
> > 
> > Another issue is that this driver uses DMA_ERROR_CODE, which is currently
> > defined on powerpc/sparc/x86 only.
> 
> Why can't use dma_mapping_error()?

http://git.infradead.org/mtd-2.6.git/commitdiff/0c82d3ce

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@xxxxxxxxx                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/