Re: [PATCH 2/2] fs/partition/msdos: Fix unusable extended partitionfor > 512B sector

From: H. Peter Anvin
Date: Thu Mar 11 2010 - 16:58:39 EST


On 03/11/2010 01:25 PM, Daniel Taylor wrote:

I have not yet tried booting from one of these disks.

They are in USB-attached enclosures,

Right...

attached well after boot, so the
bootloader has never seen them.

Wrong. A lot of BIOSes will attempt to boot from USB storage. Worse, a fair number of BIOSes will hang during startup if a USB storage device that confuses them -- even if not the primary boot device.

They simply refuse to mount to a running
Linux system because, when the storage for partition size and start was
expanded to 64-bit, no one bothered to fix the intermediate storage in
msdos.c, so the kernel cannot locate the start nor figure the size of
the partitions.

Logically, this patch is not complicated. The data types in msdos.c
are flat-out wrong, given that the real stored data is of type sector_t.
The intermediate variables should not be u32.

I would consider this a bugfix. As such, it should be pushed outside the merge window.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/