Re: [PATCH 01/11] ST SPEAr: Added ARM PrimeXsys System ControllerSP810 header file
From: Viresh KUMAR
Date: Fri Mar 12 2010 - 00:20:53 EST
On 3/11/2010 4:15 PM, Russell King - ARM Linux wrote:
> On Tue, Mar 09, 2010 at 09:14:53PM +0100, Linus Walleij wrote:
>> 2010/3/3 Viresh KUMAR <viresh.kumar@xxxxxx>:
>>
>>> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxx>
>>> ---
>>> include/linux/sysctl_sp810.h | 59 ++++++++++++++++++++++++++++++++++++++++++
>>> 1 files changed, 59 insertions(+), 0 deletions(-)
>>> create mode 100644 include/linux/sysctl_sp810.h
>>> (...)
>>
>> To the rest of the world this is probably a number of register definitions and
>> an obscure inline function, so the entire internal kernel API does not need
>> to know about it.
>
> It'll also give people heart-attacks because they'll think it adds a new
> set of deprecated binary sysctl() interfaces to the kernel.
>
> Best drop the 'sysctl' part of the name as well.
>
OK. will be removed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/