Re: [PATCH 1/2] Add support for Olimex SAM9-L9261 SBC

[Russell King - ARM Linux]

On Fri, Mar 12, 2010 at 10:04:54AM +0000, Russell King - ARM Linux wrote:
> On Fri, Mar 12, 2010 at 11:00:32AM +0100, Benjamin Valentin wrote:
> > diff -urpN -x CVS linux-2.6.34-rc1/arch/arm/configs/sam9_l9261_defconfig linux-2.6.34-rc1-olimex/arch/arm/configs/sam9_l9261_defconfig
> > --- linux-2.6.34-rc1/arch/arm/configs/sam9_l9261_defconfig	1970-01-01 02:00:00.000000000 +0200
> > +++ linux-2.6.34-rc1-olimex/arch/arm/configs/sam9_l9261_defconfig	2008-10-28 06:08:46.000000000 +0200
> > @@ -0,0 +1,1606 @@
> 
> Please think about your reviewers when you send patches - do you think
> it's reasonable to expect reviewers to scroll through 1600 lines before
> they get to something interesting to read?
> 
> Always split defconfig patches into a separate patch.

Oh, and please include a diffstat and signed-off-by lines as per
Documentation/SubmittingPatches.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/