Re: [PATCH] devtmpfs: support !CONFIG_TMPFS

[Kay Sievers]

On Fri, Mar 12, 2010 at 12:38, Peter Korsgaard <jacmet@xxxxxxxxxx> wrote:
>>>>>> "Michael" == Michael Tokarev <mjt@xxxxxxxxxx> writes:
> Â>> +#ifdef CONFIG_TMPFS
> Â>> return get_sb_single(fs_type, flags, data, shmem_fill_super, mnt);
> Â>> +#else
> Â>> + Â return get_sb_single(fs_type, flags, data, ramfs_fill_super, mnt);
> Â>> +#endif
> Â>> }
>
> ÂMichael> May be completely not to the point or even wrong, but I were
> ÂMichael> starring at this change for quite some time trying to understand
> ÂMichael> what's the difference. ÂCan we do it like this:
>
> ÂMichael> #ifdef CONFIG_TMPFS
> ÂMichael> # define devtmpfs_fill_super shmem_fill_super
> ÂMichael> #else
> ÂMichael> # define devtmpfs_fill_super ramfs_fill_super
> ÂMichael> #endif
> ÂMichael> Â Â Â return get_sb_single(fs_type, flags, data, devtmpfs_fill_super, mnt);

> Sure, if people find that cleaner - Kay?

For the style:
  I would prefer your original version.

For the patch:
  Acked-by: Kay Sievers <kay.sievers@xxxxxxxx>

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/