Re: [PATCH] [mtd, nandsim] Fix typo: struct nandsin_geometry
From: Andrew Morton
Date: Fri Mar 12 2010 - 17:56:59 EST
On Sat, 06 Mar 2010 20:08:00 +0100
Ferenc Wagner <wferi@xxxxxxx> wrote:
> Subject: [PATCH] [mtd, nandsim] Fix typo: struct nandsin_geometry
fyi, the text inside [] is conventionally considered "transient, to be
removed by receiver", so you should have placed the
subsystem-identification text outside the [].
> Actually, this embedded struct (together with nandsim_regs) could as well
> remain nameless...
>
Sounds like a fine idea.
> ---
> drivers/mtd/nand/nandsim.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
> index 7281000..803ae12 100644
> --- a/drivers/mtd/nand/nandsim.c
> +++ b/drivers/mtd/nand/nandsim.c
> @@ -312,7 +312,7 @@ struct nandsim {
> union ns_mem buf;
>
> /* NAND flash "geometry" */
> - struct nandsin_geometry {
> + struct nandsim_geometry {
> uint64_t totsz; /* total flash size, bytes */
> uint32_t secsz; /* flash sector (erase block) size, bytes */
> uint pgsz; /* NAND flash page size, bytes */
this:
From: Ferenc Wagner <wferi@xxxxxxx>
The name was spelled wrong. We don't need an identifier on this struct
anyway, so remove it altogether.
Signed-off-by: Ferenc Wagner <wferi@xxxxxxx>
Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/mtd/nand/nandsim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/mtd/nand/nandsim.c~mtd-nandsim-fix-typo-struct-nandsin_geometry drivers/mtd/nand/nandsim.c
--- a/drivers/mtd/nand/nandsim.c~mtd-nandsim-fix-typo-struct-nandsin_geometry
+++ a/drivers/mtd/nand/nandsim.c
@@ -315,7 +315,7 @@ struct nandsim {
union ns_mem buf;
/* NAND flash "geometry" */
- struct nandsin_geometry {
+ struct {
uint64_t totsz; /* total flash size, bytes */
uint32_t secsz; /* flash sector (erase block) size, bytes */
uint pgsz; /* NAND flash page size, bytes */
_
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/