Re: [patch 2/3] genirq: warn about IRQF_SHARED|IRQF_DISABLED at theright place

From: Andrew Morton
Date: Fri Mar 12 2010 - 20:17:53 EST


On Sat, 13 Mar 2010 01:59:50 +0100 (CET) Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

>
> I'm simply refusing to apply patches which just shuffle code around to
> warn about obscure use cases instead of tackling the real problem of
> long running irq handlers which prevent us to get rid of IRQF_DISABLED
> and just run all interrupt handlers with irqs disabled.

I'm having trouble agreeing with that aim, really.

We can tweak and tune until we're blue in the face, but the system's
IRQ latency will always be worse if handlers always run with interrupts
disabled.

Plus this approach introduces dependencies between unrelated drivers
(and between _each_ driver and the overall system) which simply don't
exist if those drivers are being nicer to the rest of the system.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/