Re: [Patch] x86,pat Update the page flags for memtype atomicallyinstead of using memtype_lock.

From: Suresh Siddha
Date: Fri Mar 12 2010 - 21:06:28 EST


On Fri, 2010-03-12 at 17:52 -0800, Thomas Gleixner wrote:
> On Fri, 12 Mar 2010, Suresh Siddha wrote:
> > Just wanted to make sure that we address the perf aspect even for non
> > RAM pages by converting the memtype_lock into rwlock before some one
> > else reports a similar issue for non RAM pages.
>
> Care to explain why a rwlock is a good solution and which problem is
> solved by the conversion of a spinlock to a rwlock ?

Thomas, This is the original posting from Robin.

http://marc.info/?l=linux-kernel&m=126720623119649&w=2

lookup_memtype() currently takes the memtype spinlock. Changing this to
a readlock will allow multiple folks to go through this in parallel.

thanks,
suresh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/