Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing codingstyle in tg3.c This is a patch to the tg3.c file that aligns switch andcase statements, else statements following braces, and inserts a spaceafter commas listed in the coding style guidelines and verified bycheckpatch.pl tool.

From: David Miller
Date: Sat Mar 13 2010 - 14:49:38 EST

Next message: Steven Harms: "Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style g"
Previous message: Bruno PrÃmont: "Re: [PATCH 1/3] picolcd: driver for PicoLCD HID device"
In reply to: Steven Harms: "[PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style guidelines and verified by checkpatch.pl tool."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

From: Steven Harms <sjharms@xxxxxxxxx>
Date: Sat, 13 Mar 2010 14:39:11 -0500

> -#define tw32_mailbox(reg, val) tp->write32_mbox(tp, reg, val)
> -#define tw32_mailbox_f(reg, val) tw32_mailbox_flush(tp, (reg), (val))
> -#define tw32_rx_mbox(reg, val) tp->write32_rx_mbox(tp, reg, val)
> -#define tw32_tx_mbox(reg, val) tp->write32_tx_mbox(tp, reg, val)
> -#define tr32_mailbox(reg) tp->read32_mbox(tp, reg)
> +#define tw32_mailbox(reg, val) (tp->write32_mbox(tp, reg, val))

Please keep this kind of code masterbation to yourself.
This is not the style we want for this driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/