Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing codingstyle in tg3.c This is a patch to the tg3.c file that aligns switch andcase statements, else statements following braces, and inserts a spaceafter commas listed in the coding style g

From: Joe Perches
Date: Sat Mar 13 2010 - 15:22:36 EST

Next message: Douglas Gilbert: "Re: [GIT PULL] final scsi updates for 2.6.34-rc1"
Previous message: David Miller: "Re: [PATCH] drivers/net/tg3.c: change the field used with theTG3_FLAG_10_100_ONLY constant"
In reply to: David Miller: "Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing codingstyle in tg3.c This is a patch to the tg3.c file that aligns switch andcase statements, else statements following braces, and inserts a spaceafter commas listed in the coding style g"
Next in thread: Matt Carlson: "Re: [PATCH] NET: tg3: fix brace, switch, and comma spacingcoding style in tg3.c This is a patch to the tg3.c file that alignsswitch and case statements, else statements following braces, andinserts a space after commas listed in the coding style g"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, 2010-03-13 at 11:55 -0800, David Miller wrote:
> From: Steven Harms <thisdyingdream@xxxxxxxxx>
> Date: Sat, 13 Mar 2010 14:52:26 -0500
>
> > Would you like me to submit the patch adding only the spaces after
> > commas and leave the rest of the defines as is, or discard the changes
> > all together?
>
> I would like you to toss them altogether.

I think that Steven got off on the wrong foot
a bit by adding the parentheses to the defines.

I think the other changes he suggested are
tree-wide style consistency only and are ok.

Perhaps you might reconsider later, after
net-next reopens.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/