Re: [patch 120/123] sched: Fix sched_mv_power_savings for !SMT

[Vaidyanathan Srinivasan]

* Greg KH <gregkh@xxxxxxx> [2010-03-12 16:13:38]:

> 2.6.33-stable review patch.  If anyone has any objections, please let me know.

Hi Greg,

Thanks to pulling this into .32 and .33-stable.  Please correct the
subject and commit message to sched_mc_power_savings when you apply.
The term sched_mv_power_savings is a typo.

"sched: Fix sched_mc_power_savings for !SMT"

Thanks,
Vaidy

Ref: http://lkml.org/lkml/2010/2/16/230

> -----------------
> 
> From: Vaidyanathan Srinivasan <svaidy@xxxxxxxxxxxxxxxxxx>
> 
> commit 28f5318167adf23b16c844b9c2253f355cb21796 upstream.
> 
> Fix for sched_mc_powersavigs for pre-Nehalem platforms.
> Child sched domain should clear SD_PREFER_SIBLING if parent will have
> SD_POWERSAVINGS_BALANCE because they are contradicting.
> 
> Sets the flags correctly based on sched_mc_power_savings.
> 
> Signed-off-by: Vaidyanathan Srinivasan <svaidy@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> LKML-Reference: <20100208100555.GD2931@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> 
> ---
>  include/linux/sched.h |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -878,7 +878,10 @@ static inline int sd_balance_for_mc_powe
>  	if (sched_smt_power_savings)
>  		return SD_POWERSAVINGS_BALANCE;
> 
> -	return SD_PREFER_SIBLING;
> +	if (!sched_mc_power_savings)
> +		return SD_PREFER_SIBLING;
> +
> +	return 0;
>  }
> 
>  static inline int sd_balance_for_package_power(void)
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/